feat(cwl): Add metric definitions for LiveTail #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 19, 2024 10:49
dhruvigajjar
approved these changes
Nov 19, 2024
dhruvigajjar
approved these changes
Nov 19, 2024
justinmk3
reviewed
Nov 27, 2024
| @@ -1297,6 +1297,11 @@ | |||
| "type": "boolean", | |||
| "description": "Whether the user has access to CodeWhisperer Chat" | |||
| }, | |||
| { | |||
| "name": "hasLogEventFilterPattern", | |||
There was a problem hiding this comment.
This is over-specific. Can you find a field name that will be useful for other metrics in the future, e.g. hasPatternFilter (why is "log event" important enough to call out in the field name?)
Another way of future-proofing is to use enum-like (or string) fields instead of booleans. It's pretty cumbersome that we have booleans for each of these variants, and may need to add even more in the future.
justinmk3
reviewed
Nov 27, 2024
| "name": "hasLogEventFilterPattern", | ||
| "type": "boolean", | ||
| "description": "If LogEvent filter pattern is applied" | ||
| }, | ||
| { | ||
| "name": "hasTextFilter", |
There was a problem hiding this comment.
How is hasLogEventFilterPattern different than this existing field?
justinmk3
reviewed
Nov 27, 2024
| @@ -4995,6 +5010,48 @@ | |||
| } | |||
| ] | |||
| }, | |||
| { | |||
| "name": "cwlLiveTail_Start", | |||
There was a problem hiding this comment.
I am certain that we have existing cloudwatch metrics. Yet these new "live tail" metrics don't use the same prefix, so now both will be harder to discover.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cloudwatch wants to monitor usage metrics of the LiveTail integration
Solution
When starting a session emit telemetry for:
When closing a session:
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.